Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41: Fix critical bug in building upgrade #43

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

Owen-Griffin
Copy link
Collaborator

@Owen-Griffin Owen-Griffin commented Jun 24, 2024

I understand the inputResponse solution on the ConstructionFrame is not a great solution, but until we figure out how to update a frame instead of generating a new one, I don't really have a better solution.

Copy link
Member

@ItsNeil17 ItsNeil17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ItsNeil17 ItsNeil17 merged commit 5ce5a2d into main Jun 24, 2024
13 checks passed
@ItsNeil17 ItsNeil17 deleted the bug/GH-41/constructionupgrade branch June 24, 2024 11:57
@wos-manager wos-manager bot requested a review from ItsNeil17 June 24, 2024 11:57
@WillofSteel-Devs WillofSteel-Devs deleted a comment from wos-manager bot Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants